Support spherical shell blocks, create Sphere domain #6392
+915
−429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add an enum to
Block
that indicates whether the block represents aCube
or aSphericalShell
. Cubes can only have one block neighbor per dimension, whereas spherical shells can have multiple block neighbors (another shell, or 4 wedges in 2D, or 6 wedges in 3D).Also adds the code to connect element neighbors across spherical and cubed shells, to create the Ylm meshes, and to create a Sphere domain with spherical shells.
Only the spherical-to-cartesian coordinate map is missing to create spherical shells in ExportCoordinates3D. The coordinate maps are in #5588, but need to be adjusted a bit because we use the spherical coordinates directly as logical coordinates, so we don't need the maps from [-1, 1] to angles.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments